Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bdc0d6) 85.56% compared to head (6b73972) 85.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files          25       25           
  Lines        2244     2244           
=======================================
  Hits         1920     1920           
  Misses        324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Anything against this? We have released v3 about a month ago, with a patch releases every week, so I think we have at least a moderate amount of exposure from users.

/cc @simolus3 @osaxma

I have migrated all my code to v3 so I have nothing against this, but

so I think we have at least a moderate amount of exposure from users

may be a bit optimistic after one month? Looking at the top packages depending on postgres, drift and postgres_crdt are the only two packages on the first page supporting postgres v3. package:postgres_pool should potentially be marked as discontinued with postgres as a replacement, but maybe we should ask authors of the other packages if they have issues with the v3 API preventing them to upgrade?

On the other hand, folks depending on the compatibility layer can always upgrade to 3.0.x first, do the migration and then upgrade all the way to the latest 3.1+ version. But perhaps this should be mentioned in the previous changelog entry (suggest upgrading to postgres: >=3.0.0 <3.1.0 first)?

Good points.

I've now discontinued postgres_pool and cockroachdb_pool (which has been neglected for a while, but I didn't have the need to update my app that used it). Which reminded me that I wanted to implement an event notification thing for the pool support, and potentially for regular connections too. I have an app that produced really useful metrics and logs based on these events, but it is no longer active/running.

Upgrading for frameworks is a tough call, and maybe I'm too optimistic about it. It is probably not much overhead at this point to keep it.